Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate AddConfirmationDto validation to zod #1253

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Migrate AddConfirmationDto validation to zod #1253

merged 3 commits into from
Mar 11, 2024

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Mar 5, 2024

Summary

This migrates the validation of AddConfirmationDto to zod.

Changes

  • Removes AddConfirmationDtoValidationPipe and associated schema
  • Adds AddConfirmationDtoSchema and infers type from it

@iamacook iamacook self-assigned this Mar 5, 2024
@coveralls
Copy link

coveralls commented Mar 5, 2024 •
edited

Pull Request Test Coverage Report for Build 8186013474

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 93.439%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/domain/transactions/entities/add-confirmation.dto.entity.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 8185873789: 0.03%
Covered Lines: 6414
Relevant Lines: 6631
💛 - Coveralls

@iamacook iamacook marked this pull request as ready for review March 5, 2024 16:54
@iamacook iamacook requested a review from a team as a code owner March 5, 2024 16:54
@iamacook iamacook merged commit 0d021af into main Mar 11, 2024
16 checks passed
@iamacook iamacook deleted the zod-add-confirmation-dto-validation branch March 11, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorgomezv hectorgomezv hectorgomezv approved these changes

Assignees

@iamacook iamacook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iamacook @coveralls @hectorgomezv