Migrate Collectible to zod
#1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8230500960Details
💛 - Coveralls |
hectorgomezv
approved these changes
Mar 8, 2024
| tokenSymbol: z.string(), | ||
| logoUri: z.string(), | ||
| id: z.string(), | ||
| // AJV remnant - do not use format: 'uri' as it fails on some payloads that should be considered valid |
There was a problem hiding this comment.
Nit: do you think the AJV reference is needed? We could just comment out that we don't enforce URL validation here, wdyt?
There was a problem hiding this comment.
I changed the comment in 01237f5 but I think we should revisit this in the future. If we can make the schemas stricter, it would be beneficial.
hectorgomezv
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This migrates the validation of
Collectibletozod.Changes
CollectiblesValidatorand associated schemaCollectibleSchemaand infers type(s) from it