Migrate Contract to zod
#1261
Merged
Migrate Contract to zod
#1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamacook
commented
Mar 6, 2024
iamacook
commented
Mar 6, 2024
| .then((c) => new AddressInfo(c.address, c.displayName, c.logoUri)); | ||
| .then( | ||
| (c) => | ||
| new AddressInfo(c.address, c.displayName, c.logoUri ?? undefined), |
There was a problem hiding this comment.
In accordance with the potential null, this needs to fallback to undefined as AddessInfo only accepts string | undefined as a logoUri.
There was a problem hiding this comment.
Wdyt about leaving a TODO to change the AddressInfo constructor to accept string | null as a logoUri in a different PR?
There was a problem hiding this comment.
Good point. I've added a comment in ea4c64b.
Pull Request Test Coverage Report for Build 8236190961Details
💛 - Coveralls |
hectorgomezv
approved these changes
Mar 8, 2024
| .then((c) => new AddressInfo(c.address, c.displayName, c.logoUri)); | ||
| .then( | ||
| (c) => | ||
| new AddressInfo(c.address, c.displayName, c.logoUri ?? undefined), |
There was a problem hiding this comment.
Wdyt about leaving a TODO to change the AddressInfo constructor to accept string | null as a logoUri in a different PR?
hectorgomezv
approved these changes
Mar 11, 2024
hectorgomezv
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This migrates the validation of
Contracttozod.Changes
ContractsValidatorand associated schemaContractSchemaand infers type from it