Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate CreateMessageDto to zod #1264

Merged
merged 8 commits into from
Mar 14, 2024
Merged

Migrate CreateMessageDto to zod #1264

merged 8 commits into from
Mar 14, 2024

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Mar 6, 2024 •
edited

Summary

This migrates the validation of CreateMessageDto to zod.

Changes

  • Removes AddConfirmationDtoValidationPipe and associated schema
  • Adds CreateMessageDtoValidationPipe and infers type from it
  • Updates associated tests

@iamacook iamacook self-assigned this Mar 6, 2024
@coveralls
Copy link

coveralls commented Mar 6, 2024 •
edited

Pull Request Test Coverage Report for Build 8277532586

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 93.44%
Totals Coverage Status
Change from base Build 8185873789: 0.04%
Covered Lines: 6415
Relevant Lines: 6632
💛 - Coveralls

@iamacook iamacook marked this pull request as ready for review March 6, 2024 14:59
@iamacook iamacook requested a review from a team as a code owner March 6, 2024 14:59
Base automatically changed from zod-union-errors to main March 6, 2024 15:23
@iamacook iamacook marked this pull request as draft March 7, 2024 08:55
@iamacook iamacook marked this pull request as ready for review March 7, 2024 11:49
@iamacook iamacook merged commit e0aa988 into main Mar 14, 2024
16 checks passed
@iamacook iamacook deleted the zod-create-message-dto-validation branch March 14, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmrsabino fmrsabino fmrsabino approved these changes

@hectorgomezv hectorgomezv hectorgomezv approved these changes

Assignees

@iamacook iamacook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iamacook @coveralls @fmrsabino @hectorgomezv