Migrate DeleteDelegateDto validation to zod
#1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8205614276Details
💛 - Coveralls |
iamacook
approved these changes
Mar 6, 2024
hectorgomezv
force-pushed
the
zod-delete-delegate-validation
branch
from
e5f2fb3
to
c18ee92
Compare
iamacook
approved these changes
Mar 7, 2024
|
I'm marking this as a draft as we need add tests for it. |
hectorgomezv
force-pushed
the
zod-delete-delegate-validation
branch
from
c18ee92
to
5642ef2
Compare
|
I've added the validation schema unit tests in 98d6b26 |
iamacook
approved these changes
Mar 11, 2024
iamacook
reviewed
Mar 11, 2024
Comment on lines
+203
to
+207
| safeAddress: string | null; | ||
| delegate: string; | ||
| delegator: string; | ||
| signature: string; | ||
| label: string; |
There was a problem hiding this comment.
The only comments I have regarding this PR, I left there.
hectorgomezv
added a commit
that referenced
this pull request
Mar 11, 2024
- Remove `DeleteDelegateDtoValidationPipe` and associated schema. - Add `DeleteDelegateDtoSchema`. - Verifiy the associated endpoint data validation by `ValidationPipe(DeleteDelegateDtoSchema)`. - Update associated tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This migrates the validation of
DeleteDelegateDtotozod.Changes
DeleteDelegateDtoValidationPipeand associated schema.DeleteDelegateDtoSchema.ValidationPipe(DeleteDelegateDtoSchema).