Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate DataDecoded to zod #1268

Merged
merged 9 commits into from
Mar 14, 2024
Merged

Migrate DataDecoded to zod #1268

merged 9 commits into from
Mar 14, 2024

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Mar 6, 2024

Summary

This migrates the validation of DataDecoded to zod.

Changes

  • Create DataDecodedSchema
  • Migrated DataDecodedRepository['getDataDecoded'] to use new schema
  • Add notes to remove to-be-deprecated validator

@iamacook iamacook self-assigned this Mar 6, 2024
@iamacook iamacook marked this pull request as ready for review March 6, 2024 17:18
@iamacook iamacook requested a review from a team as a code owner March 6, 2024 17:18
@coveralls
Copy link

coveralls commented Mar 6, 2024 •
edited

Pull Request Test Coverage Report for Build 8283755095

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 93.621%
Files with Coverage Reduction New Missed Lines %
src/domain/data-decoder/data-decoded.validator.ts 1 90.0%
Totals Coverage Status
Change from base Build 8281313744: -0.04%
Covered Lines: 6374
Relevant Lines: 6578
💛 - Coveralls

@iamacook iamacook mentioned this pull request Mar 6, 2024
Merged
@iamacook iamacook marked this pull request as draft March 7, 2024 08:56
@iamacook iamacook marked this pull request as ready for review March 7, 2024 12:18
@iamacook iamacook marked this pull request as draft March 7, 2024 15:30
@iamacook iamacook marked this pull request as ready for review March 14, 2024 13:32
hectorgomezv
hectorgomezv approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@hectorgomezv hectorgomezv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left small doubts only, otherwise LGTM.

src/domain/data-decoder/entities/schemas/data-decoded.schema.ts Outdated Show resolved Hide resolved
@iamacook iamacook merged commit 869cc5f into main Mar 14, 2024
16 checks passed
@iamacook iamacook deleted the zod-data-decoded-validation branch March 14, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorgomezv hectorgomezv hectorgomezv approved these changes

Assignees

@iamacook iamacook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iamacook @coveralls @hectorgomezv