Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Estimation to zod #1271

Merged
merged 6 commits into from
Mar 14, 2024
Merged

Migrate Estimation to zod #1271

merged 6 commits into from
Mar 14, 2024

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Mar 7, 2024

Summary

This migrates the validation of Estimation to zod.

Changes

  • Remove EstimationsValidator and associated schema.
  • Add EstimationSchema and infer types from it.
  • Update associated tests.

@iamacook iamacook self-assigned this Mar 7, 2024
@coveralls
Copy link

coveralls commented Mar 7, 2024 •
edited

Pull Request Test Coverage Report for Build 8284117192

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 93.599%
Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/tests/human-description.builder.ts 4 60.0%
Totals Coverage Status
Change from base Build 8283676068: -0.05%
Covered Lines: 6466
Relevant Lines: 6677
💛 - Coveralls

@iamacook iamacook marked this pull request as ready for review March 7, 2024 08:09
@iamacook iamacook requested a review from a team as a code owner March 7, 2024 08:09
@hectorgomezv hectorgomezv self-requested a review March 14, 2024 14:44
@iamacook iamacook merged commit 5293d98 into main Mar 14, 2024
16 checks passed
@iamacook iamacook deleted the zod-estimation-validation branch March 14, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorgomezv hectorgomezv hectorgomezv approved these changes

Assignees

@iamacook iamacook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iamacook @coveralls @hectorgomezv