Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coerce order amounts to bigint #1298

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Coerce order amounts to bigint #1298

merged 1 commit into from
Mar 14, 2024

Conversation

fmrsabino
Copy link
Collaborator

  • Coerces the order amounts from a string to a bigint.
  • This change will enable doing arithmetic operations without validating and converting the respective values to a number.

@fmrsabino fmrsabino self-assigned this Mar 13, 2024
@fmrsabino fmrsabino requested a review from a team as a code owner March 13, 2024 15:50
- Coerces the order amounts from a `string` to a `bigint`.
- This change will enable doing arithmetic operations without validating and converting the respective values to a number.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8267898159

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 93.697%

Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/tests/human-description.builder.ts 1 90.0%
Totals Coverage Status
Change from base Build 8266258691: -0.001%
Covered Lines: 6361
Relevant Lines: 6564

💛 - Coveralls

@fmrsabino fmrsabino merged commit a7b973d into main Mar 14, 2024
16 checks passed
@fmrsabino fmrsabino deleted the update-order-schema branch March 14, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants