Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locking history pagination #1300

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Fix locking history pagination #1300

merged 1 commit into from
Mar 15, 2024

Conversation

iamacook
Copy link
Member

Summary

This fixes the locking history pagination. Previously the arguments were being directly passed and, as offset and limit are optional`, there was not warning regarding incorrect parameters.

Changes

  • Explicitly pass offset and limit to locking history endpoint
  • Add test coverage for pagination

@iamacook iamacook self-assigned this Mar 14, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8280421275

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 93.652%

Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/tests/human-description.builder.ts 2 60.0%
Totals Coverage Status
Change from base Build 8268054245: -0.02%
Covered Lines: 6359
Relevant Lines: 6565

💛 - Coveralls

@iamacook iamacook marked this pull request as ready for review March 14, 2024 12:30
@iamacook iamacook requested a review from a team as a code owner March 14, 2024 12:30
@iamacook iamacook merged commit 9a8188b into main Mar 15, 2024
16 checks passed
@iamacook iamacook deleted the locking-history-pagination branch March 15, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants