Add OrderSchema tests #1302
Merged
Add OrderSchema tests #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds `SwapOrderMapper` – this mapper will attempt to decode transactions that represent a `preSignature` CoW Swap order. - Successful decoding depends on multiple conditions. If any of the following conditions occurs, the transaction is mapped to a custom transaction instead (i.e.: without any decoding in place): * Transaction data is null * Order UID cannot be retrieved * Buy or Sell token info cannot be retrieved * Unsupported order statuses (statuses which are not `fulfilled`, `open`, `cancelled` or `expired`). - Adds an `orderBuilder` to support creating multiple instances of `Order` with different properties. - The decoding of CoW Swap orders is only available if `FF_SWAPS_DECODING` is enabled.
Pull Request Test Coverage Report for Build 8295780648Details
💛 - Coveralls |
iamacook
requested changes
Mar 14, 2024
There was a problem hiding this comment.
Can we also add test conditions for:
- Address checksumming of
sellToken,buyToken,receiver,from,owner,onChainUserandonchainUser.sender - Defaulting to
nullforreceiver,from,quoteId,availableBalance,ethflowData,onchainUser,executedSurplusFeeandfullAppData.
I've also noticed that there are some hexadecimal values that could use the HexSchema in the OrderSchema that could then be tested as well: signature and ethflowData.refundTxHash.
Co-authored-by: Aaron Cook <aaron@safe.global>
iamacook
approved these changes
Mar 15, 2024
| expect(result.success && result.data.kind).toBe('unknown'); | ||
| }); | ||
|
|
||
| it.each<keyof Order>([ |
iamacook
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
OrderSchema.Changes
.default('unknown')to.catch('unknown')in theOrderSchemaas the default value would only be set if no value was provided. If an unknown value is provided we should still set the respective value asunknown.