Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate SafeList to zod #1311

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Migrate SafeList to zod #1311

merged 3 commits into from
Mar 18, 2024

Conversation

iamacook
Copy link
Member

Summary

This migrates the validation of SafeList to zod.

Changes

  • Remove SafeListValidator and associated schemas.
  • Add test-covered SafeListSchema and infer type from it.
  • Propagate type requirements.
  • Update tests accordingly.

@iamacook iamacook self-assigned this Mar 15, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8298259414

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 93.615%
Totals Coverage Status
Change from base Build 8297934250: -0.02%
Covered Lines: 6469
Relevant Lines: 6677
💛 - Coveralls

@iamacook iamacook marked this pull request as ready for review March 15, 2024 15:21
@iamacook iamacook requested a review from a team as a code owner March 15, 2024 15:21
@iamacook iamacook merged commit d0779a3 into main Mar 18, 2024
16 checks passed
@iamacook iamacook deleted the zod-safe-list branch March 18, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmrsabino fmrsabino fmrsabino approved these changes

Assignees

@iamacook iamacook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iamacook @coveralls @fmrsabino