Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Singleton to zod #1312

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Migrate Singleton to zod #1312

merged 2 commits into from
Mar 18, 2024

Conversation

iamacook
Copy link
Member

Summary

This migrates the validation of Singleton to zod.

Changes

  • Remove SingletonValidator and associated schemas.
  • Add test-covered SingletonSchema and infer type from it.
  • Propagate type requirements.
  • Update tests accordingly.

@iamacook iamacook self-assigned this Mar 15, 2024
@coveralls
Copy link

coveralls commented Mar 15, 2024 •
edited

Pull Request Test Coverage Report for Build 8326375056

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 93.694%
Totals Coverage Status
Change from base Build 8326358957: 0.05%
Covered Lines: 6507
Relevant Lines: 6713
💛 - Coveralls

@iamacook iamacook marked this pull request as ready for review March 15, 2024 15:40
@iamacook iamacook requested a review from a team as a code owner March 15, 2024 15:40
@iamacook iamacook merged commit abe1f0c into main Mar 18, 2024
16 checks passed
@iamacook iamacook deleted the zod-singleton branch March 18, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorgomezv hectorgomezv hectorgomezv approved these changes

Assignees

@iamacook iamacook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iamacook @coveralls @hectorgomezv