Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate UpdateMessageSignatureDto to zod #1334

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Migrate UpdateMessageSignatureDto to zod #1334

merged 2 commits into from
Mar 21, 2024

Conversation

iamacook
Copy link
Member

Summary

This migrates the validation of UpdateMessageSignatureDto to zod.

Changes

  • Remove UpdateMessageSignatureDtoValidationPipe and associated schemas.
  • Add test-covered UpdateMessageSignatureDtoSchema and infer types from it.
  • Propagate type requirements.
  • Update tests accordingly.

@iamacook iamacook self-assigned this Mar 20, 2024
@iamacook iamacook marked this pull request as ready for review March 20, 2024 08:42
@iamacook iamacook requested a review from a team as a code owner March 20, 2024 08:42
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8355957040

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 93.384%
Totals Coverage Status
Change from base Build 8347022186: 0.1%
Covered Lines: 6470
Relevant Lines: 6683
💛 - Coveralls

@iamacook iamacook merged commit 4c4c503 into main Mar 21, 2024
16 checks passed
@iamacook iamacook deleted the update-message-signature-dto-zod branch March 21, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmrsabino fmrsabino fmrsabino approved these changes

Assignees

@iamacook iamacook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iamacook @coveralls @fmrsabino