Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Order entity and schema files #1337

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Merge Order entity and schema files #1337

merged 1 commit into from
Mar 21, 2024

Conversation

fmrsabino
Copy link
Collaborator

@fmrsabino fmrsabino commented Mar 20, 2024

  • Merges the OrderSchema with the Order entity (on a file level).
  • The main reason for this change is that most of the entities are a single-line Zod call to infer the schema. By merging both the schema and the entity we reduce the level of indirection for navigating the project (the schema is the core component of the entity).

@fmrsabino fmrsabino self-assigned this Mar 20, 2024
@coveralls
Copy link

coveralls commented Mar 20, 2024

Pull Request Test Coverage Report for Build 8376634212

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 93.347%

Totals Coverage Status
Change from base Build 8372182365: 0.02%
Covered Lines: 6461
Relevant Lines: 6677

💛 - Coveralls

@fmrsabino fmrsabino marked this pull request as ready for review March 20, 2024 15:38
@fmrsabino fmrsabino requested a review from a team as a code owner March 20, 2024 15:38
hectorgomezv
hectorgomezv previously approved these changes Mar 20, 2024
iamacook
iamacook previously approved these changes Mar 21, 2024
@fmrsabino fmrsabino changed the base branch from improve-order-swagger to main March 21, 2024 14:26
@fmrsabino fmrsabino dismissed stale reviews from iamacook and hectorgomezv March 21, 2024 14:26

The base branch was changed.

@fmrsabino fmrsabino merged commit 39b05c3 into main Mar 21, 2024
16 checks passed
@fmrsabino fmrsabino deleted the merge-schema-entity branch March 21, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants