Add filledPercentage to SwapOrderTransactionInfo #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8390537987Details
💛 - Coveralls |
fmrsabino
force-pushed
the
merge-schema-entity
branch
from
c60ae8e
to
b6297fd
Compare
fmrsabino
force-pushed
the
order-fill-status
branch
from
4cbb877
to
5b816cb
Compare
iamacook
approved these changes
Mar 22, 2024
src/routes/transactions/mappers/common/swap-order.mapper.spec.ts
Outdated
Show resolved
Hide resolved
iamacook
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
filledPercentageto theSwapOrderTransactionInfo– it represents how much the order was filled in percentual terms (returning the first two decimal digits).