Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type and validate Rank['position'] as a number #1339

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Change type and validate Rank['position'] as a number #1339

merged 1 commit into from
Mar 22, 2024

Conversation

iamacook
Copy link
Member

Summary

This changes the type and validation of Rank['position'] from a numeric string to a number.

Changes

  • Change position validation in RankSchema
  • Propagate type changes upwards and across tests

@iamacook iamacook self-assigned this Mar 21, 2024
@iamacook iamacook marked this pull request as ready for review March 21, 2024 14:29
@iamacook iamacook requested a review from a team as a code owner March 21, 2024 14:29
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8376593627

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 93.358%
Totals Coverage Status
Change from base Build 8372182365: 0.03%
Covered Lines: 6462
Relevant Lines: 6677
💛 - Coveralls

@iamacook iamacook merged commit 22e61b4 into main Mar 22, 2024
16 checks passed
@iamacook iamacook deleted the rank-position-type branch March 22, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorgomezv hectorgomezv hectorgomezv approved these changes

Assignees

@iamacook iamacook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iamacook @coveralls @hectorgomezv