-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DomainModule #1367
Remove DomainModule #1367
Conversation
98b8a08
to
2d75358
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏻👏🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a follow up, we should align the style of the existing domain-specific modules. There are some that are in separate files, e.g. *.domain.module.ts
.
I agree. I've left them in the same file as most of the new ones are only about the component that is present on the same file. |
7199116
to
75e40c0
Compare
The base branch was changed.
- The `DomainModule` was removed in favor of smaller domain modules. - Each feature now should explicitly declare which section of the domain is required in their respective modules. - This increases encapsulation of the provided features. For Dynamic Modules, it allows loading only the required components instead of the entire domain.
2d75358
to
8407ae7
Compare
Pull Request Test Coverage Report for Build 8567817454Details
💛 - Coveralls |
DomainModule
was removed in favor of smaller domain modules.