Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DomainModule #1367

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Remove DomainModule #1367

merged 1 commit into from
Apr 5, 2024

Conversation

fmrsabino
Copy link
Collaborator

@fmrsabino fmrsabino commented Apr 4, 2024

  • The DomainModule was removed in favor of smaller domain modules.
  • Each feature now should explicitly declare which section of the domain is required in their respective modules.
  • This increases encapsulation of the provided features. For Dynamic Modules, it allows loading only the required components instead of the entire domain.

@fmrsabino fmrsabino self-assigned this Apr 4, 2024
@fmrsabino fmrsabino requested a review from a team as a code owner April 4, 2024 20:02
hectorgomezv
hectorgomezv previously approved these changes Apr 5, 2024
Copy link
Member

@hectorgomezv hectorgomezv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻👏🏻

iamacook
iamacook previously approved these changes Apr 5, 2024
Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow up, we should align the style of the existing domain-specific modules. There are some that are in separate files, e.g. *.domain.module.ts.

@fmrsabino
Copy link
Collaborator Author

As a follow up, we should align the style of the existing domain-specific modules. There are some that are in separate files, e.g. *.domain.module.ts.

I agree. I've left them in the same file as most of the new ones are only about the component that is present on the same file.

@fmrsabino fmrsabino force-pushed the remove-global-tx-api-module branch from 7199116 to 75e40c0 Compare April 5, 2024 09:33
Base automatically changed from remove-global-tx-api-module to main April 5, 2024 09:38
@fmrsabino fmrsabino dismissed stale reviews from iamacook and hectorgomezv April 5, 2024 09:38

The base branch was changed.

- The `DomainModule` was removed in favor of smaller domain modules.
- Each feature now should explicitly declare which section of the domain is required in their respective modules.
- This increases encapsulation of the provided features. For Dynamic Modules, it allows loading only the required components instead of the entire domain.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8567817454

Details

  • 114 of 114 (100.0%) changed or added relevant lines in 38 files are covered.
  • 20 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 92.666%

Files with Coverage Reduction New Missed Lines %
src/datasources/human-description-api/human-description-api.module.ts 4 0.0%
src/datasources/transaction-api/transaction-api.module.ts 7 0.0%
src/domain/data-decoder/data-decoded.validator.ts 9 0.0%
Totals Coverage Status
Change from base Build 8567811485: -0.2%
Covered Lines: 6608
Relevant Lines: 6884

💛 - Coveralls

@fmrsabino fmrsabino merged commit 0d7fb25 into main Apr 5, 2024
16 checks passed
@fmrsabino fmrsabino deleted the split-domain-module branch April 5, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants