Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract schema validation logic #1371

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Extract schema validation logic #1371

merged 1 commit into from
Apr 9, 2024

Conversation

fmrsabino
Copy link
Collaborator

  • The validate function was rewritten to add the ability to provide the schema to validate against to the caller.
  • Adds support for returning multiple errors for the same field.

- The `validate` function was rewritten to add the ability to provide the schema to validate against to the caller.
- Adds support for returning multiple errors for the same field.
@fmrsabino fmrsabino self-assigned this Apr 5, 2024
@fmrsabino fmrsabino requested a review from a team as a code owner April 5, 2024 15:00
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8571774975

Details

  • 9 of 10 (90.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 92.6%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/config/configuration.validator.ts 5 6 83.33%
Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/tests/human-description.builder.ts 4 60.0%
Totals Coverage Status
Change from base Build 8568151290: -0.04%
Covered Lines: 6600
Relevant Lines: 6881

💛 - Coveralls

@hectorgomezv hectorgomezv added the in review Someone is reviewing this Pull Request label Apr 9, 2024
@hectorgomezv hectorgomezv removed the in review Someone is reviewing this Pull Request label Apr 9, 2024
@fmrsabino fmrsabino merged commit d61f215 into main Apr 9, 2024
16 checks passed
@fmrsabino fmrsabino deleted the extract-validator-logic branch April 9, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants