-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Alerts configuration #1372
Conversation
c5ae271
to
9da9912
Compare
Pull Request Test Coverage Report for Build 8644648086Details
💛 - Coveralls |
- The Alerts related configuration and environment keys were extracted to the AlertsApiModule and AlertsControllerModule. - These modules are dynamic so we should not load and validate the respective configuration if they are not supposed to be available in the dependency graph. - In order to avoid key collision, the feature level configuration now uses namespaces (with `registerAs`).
@@ -171,7 +164,7 @@ export default (): ReturnType<typeof configuration> => ({ | |||
express: { jsonLimit: '1mb' }, | |||
features: { | |||
richFragments: true, | |||
email: true, | |||
email: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was set to false
because otherwise, every test would have to include the now optional Alerts configuration (resulting in more changes).
Since this feature is opt-in, each test should decide if it should include the feature or not.
src/datasources/alerts-api/configuration/alerts-api.configuration.ts
Outdated
Show resolved
Hide resolved
src/datasources/alerts-api/configuration/alerts-api.configuration.module.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏻
AlertsApiModule
andAlertsControllerModule
.registerAs
).alerts-api
for keys used in/datasources/alerts-api
alerts-route
for keys used in/routes/alerts