Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SiWe nonce generation #1373

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Improve SiWe nonce generation #1373

merged 2 commits into from
Apr 8, 2024

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Apr 8, 2024

Summary

This improves the nonce generation for SiWe messages, favouring generation instead of modifying a UUID.

Changes

  • Leverage crypto.getRandomValues over crypto.randomUUID.

@iamacook iamacook self-assigned this Apr 8, 2024
@coveralls
Copy link

coveralls commented Apr 8, 2024 •
edited

Pull Request Test Coverage Report for Build 8598609979

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 92.77%
Totals Coverage Status
Change from base Build 8568151290: 0.1%
Covered Lines: 6514
Relevant Lines: 6780
💛 - Coveralls

@iamacook iamacook marked this pull request as ready for review April 8, 2024 10:25
@iamacook iamacook requested a review from a team as a code owner April 8, 2024 10:25
@iamacook iamacook merged commit 022901b into main Apr 8, 2024
16 checks passed
@iamacook iamacook deleted the siwe-nonce branch April 8, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmrsabino fmrsabino fmrsabino approved these changes

Assignees

@iamacook iamacook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iamacook @coveralls @fmrsabino