Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve robustness of RelayLegacyDtoSchema #1374

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Apr 8, 2024

Summary

This changes the mock data of chainId in the RelayLegacyDtoSchema test to always be alpha, not alphanumeric, as the latter could return a numerical string.

@iamacook iamacook self-assigned this Apr 8, 2024
@iamacook iamacook requested a review from a team as a code owner April 8, 2024 10:39
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8598655615

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 92.64%

Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/tests/human-description.builder.ts 4 60.0%
Totals Coverage Status
Change from base Build 8568151290: 0.0%
Covered Lines: 6599
Relevant Lines: 6879

💛 - Coveralls

@iamacook iamacook merged commit 801e23d into main Apr 9, 2024
16 checks passed
@iamacook iamacook deleted the legacy-relay-schema-robustness branch April 9, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants