Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token used for fee label #1391

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Fix token used for fee label #1391

merged 1 commit into from
Apr 10, 2024

Conversation

fmrsabino
Copy link
Collaborator

The sell token should be used for the fee label (instead of the buy token).

@fmrsabino fmrsabino self-assigned this Apr 10, 2024
@fmrsabino fmrsabino requested a review from a team as a code owner April 10, 2024 14:45
@coveralls
Copy link

coveralls commented Apr 10, 2024

Pull Request Test Coverage Report for Build 8633684968

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 93.033%

Totals Coverage Status
Change from base Build 8633616616: 0.02%
Covered Lines: 6724
Relevant Lines: 6973

💛 - Coveralls

The sell token should be used for the fee label (instead of the buy token).
@fmrsabino
Copy link
Collaborator Author

Had to fix some conflicts @iamacook 🙇

@fmrsabino fmrsabino merged commit 1d3c9b7 into main Apr 10, 2024
16 checks passed
@fmrsabino fmrsabino deleted the fix-token-used-fee branch April 10, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants