Omit erroneous overview elements #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8686808883Details
💛 - Coveralls |
| it('forwards error responses from the Config Service', async () => { | ||
| const chain = chainBuilder().with('chainId', '10').build(); | ||
| const safeInfo = safeBuilder().build(); | ||
| it('omits erroroneous Safes on chains returning an error from the Config Service', async () => { |
| it('forwards error responses from the Transaction Service', async () => { | ||
| const chain = chainBuilder().with('chainId', '10').build(); | ||
| const safeInfo = safeBuilder().build(); | ||
| it('omits erroroneous Safes from the Transaction Service', async () => { |
| const tokenAddress = faker.finance.ethereumAddress(); | ||
| const secondTokenAddress = faker.finance.ethereumAddress(); | ||
| const transactionApiBalancesResponse = [ | ||
| it('omits erroroneous Safes validation of the Transaction Service return Promise.rejects', async () => { |
|
Superb job! I've left a tiny nit thing only. |
iamacook
changed the title
hectorgomezv
approved these changes
Apr 12, 2024
fmrsabino
approved these changes
Apr 15, 2024
fmrsabino
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This filters the return array of the Safe overview endpoint (
/v1/safes), removing any elements that threw. This prevents one thrown retrieval of aSafeOverviewfrom blocking others.Changes
Promise.alltoPromise.allSettled'rejected'elements, logging if existent