Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add surplusLabel to Order #1395

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Add surplusLabel to Order #1395

merged 2 commits into from
Apr 12, 2024

Conversation

fmrsabino
Copy link
Collaborator

  • Adds the surplus property to a Fulfilled order.
  • The surplus is computed with the absolute difference between the initial token amount and the executed amount of the order.

- Adds the surplus property to a Fulfilled order.
- The surplus is computed with the absolute difference between the initial token amount and the executed amount of the order.
@fmrsabino fmrsabino self-assigned this Apr 11, 2024
@fmrsabino fmrsabino requested a review from a team as a code owner April 11, 2024 14:46
@coveralls
Copy link

coveralls commented Apr 11, 2024

Pull Request Test Coverage Report for Build 8649149663

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 93.018%

Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/tests/human-description.builder.ts 1 90.0%
Totals Coverage Status
Change from base Build 8647415064: 0.05%
Covered Lines: 6763
Relevant Lines: 7016

💛 - Coveralls

Co-authored-by: Aaron Cook <aaron@safe.global>
@fmrsabino fmrsabino requested a review from iamacook April 11, 2024 15:17
@fmrsabino fmrsabino merged commit 12eeb75 into main Apr 12, 2024
16 checks passed
@fmrsabino fmrsabino deleted the add-surplusLabel branch April 12, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants