Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary address checksumming #1400

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Remove unnecessary address checksumming #1400

merged 2 commits into from
Apr 12, 2024

Conversation

iamacook
Copy link
Member

Summary

This removes the unnecessary address checksumming when determining the MasterCopyVersionState of a Safe now that the relevant schemas are in place.

@iamacook iamacook self-assigned this Apr 12, 2024
@coveralls
Copy link

coveralls commented Apr 12, 2024 •
edited

Pull Request Test Coverage Report for Build 8661467499

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 93.03%
Totals Coverage Status
Change from base Build 8659994084: -0.001%
Covered Lines: 6766
Relevant Lines: 7018
💛 - Coveralls

@iamacook iamacook marked this pull request as ready for review April 12, 2024 10:26
@iamacook iamacook requested a review from a team as a code owner April 12, 2024 10:26
@iamacook iamacook merged commit 5c99aef into main Apr 12, 2024
16 checks passed
@iamacook iamacook deleted the remove-checksumming branch April 12, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorgomezv hectorgomezv hectorgomezv approved these changes

Assignees

@iamacook iamacook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iamacook @coveralls @hectorgomezv