Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for presignaturePending orders #1404

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Add support for presignaturePending orders #1404

merged 1 commit into from
Apr 15, 2024

Conversation

fmrsabino
Copy link
Collaborator

  • presignaturePending orders are now decoded.
  • This is a new requirement as orders in this state were not previously supported.

@fmrsabino
Add support for presignaturePending orders
9303b18 
- presignaturePending orders are now decoded.
- This is a new requirement as orders in this state were not previously supported.
@fmrsabino fmrsabino self-assigned this Apr 15, 2024
@fmrsabino fmrsabino requested a review from a team as a code owner April 15, 2024 11:55
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8688598336

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 93.089%
Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/tests/human-description.builder.ts 1 80.0%
src/routes/transactions/mappers/common/swap-order.mapper.ts 1 90.11%
Totals Coverage Status
Change from base Build 8687143248: 0.03%
Covered Lines: 6775
Relevant Lines: 7029
💛 - Coveralls

usame-algan
usame-algan approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@fmrsabino fmrsabino merged commit 88ebacf into main Apr 15, 2024
16 checks passed
@fmrsabino fmrsabino deleted the presignaturePending-support branch April 15, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usame-algan usame-algan usame-algan approved these changes

@iamacook iamacook iamacook approved these changes

@compojoom compojoom Awaiting requested review from compojoom

Assignees

@fmrsabino fmrsabino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fmrsabino @coveralls @usame-algan @iamacook