Add expiration time limit #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8741272486Details
💛 - Coveralls |
| @@ -2,10 +2,18 @@ import { siweMessageBuilder } from '@/domain/siwe/entities/__tests__/siwe-messag | |||
| import { VerifyAuthMessageDtoSchema } from '@/routes/auth/entities/verify-auth-message.dto.entity'; | |||
| import { faker } from '@faker-js/faker'; | |||
|
|
|||
| const MAX_VALIDITY_PERIOD_IN_MS = 15 * 60 * 1_000; // 15 minutes | |||
|
|
|||
| describe('VerifyAuthMessageDto', () => { | |||
There was a problem hiding this comment.
Maybe I'm not getting it 100% right here, but I'm thinking whether we should call jest.useFakeTimers also here (as in AuthController tests) or not, to make sure the edge cases (faker returning threshold dates) doesn't make the tests flaky.
There was a problem hiding this comment.
That's true. I've adjusted it to include fake timers in 8fdb401.
hectorgomezv
approved these changes
Apr 18, 2024
hectorgomezv
approved these changes
Apr 18, 2024
fmrsabino
pushed a commit
that referenced
this pull request
Apr 19, 2024
Adds a 15 minute limit for the validity period of JWT tokens. (It is currently hardcoded, but will eventually be injected.): - Change the `SiweMessageSchema` to a function that accepts a validity period. - Pass a value to `getSiweMessageSchema` in `VerifyAuthMessageDto`. - Add test case, as well as update existing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a 15 minute limit for the validity period of JWT tokens. (It is currently hardcoded, but will eventually be injected.)
Changes
SiweMessageSchemato a function that accepts a validity period.getSiweMessageSchemainVerifyAuthMessageDto.