Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chain_id claim to token #1416

Merged
merged 7 commits into from
Apr 18, 2024
Merged

Add chain_id claim to token #1416

merged 7 commits into from
Apr 18, 2024

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Apr 16, 2024

Summary

This adds a new chain_id claim to our authentication token.

SiWe sessions are chain-specific and routes pertaining to certain chains will to determine the chain of a session. As such, the session chain has been added to the token payload for later verification.

Changes

  • Add chain_id to JwtAccessTokenPayload
  • Add/update test coverage accordingly.

@iamacook iamacook self-assigned this Apr 16, 2024
@coveralls
Copy link

coveralls commented Apr 16, 2024

Pull Request Test Coverage Report for Build 8723067172

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 93.113%

Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/tests/human-description.builder.ts 1 90.0%
Totals Coverage Status
Change from base Build 8722902980: -0.02%
Covered Lines: 6807
Relevant Lines: 7060

💛 - Coveralls

@iamacook iamacook marked this pull request as ready for review April 16, 2024 15:46
@iamacook iamacook requested a review from a team as a code owner April 16, 2024 15:47
Base automatically changed from cookie-auth to main April 17, 2024 13:35
@iamacook iamacook merged commit ae89497 into main Apr 18, 2024
16 checks passed
@iamacook iamacook deleted the jwt-chain-id branch April 18, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants