Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SwapOrderMapper dependency injection #1436

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Fix SwapOrderMapper dependency injection #1436

merged 1 commit into from
Apr 22, 2024

Conversation

fmrsabino
Copy link
Collaborator

Summary

The SwapOrderHelper was being injected incorrectly by requesting a IConfigurationService from the graph.

This was caused by the following refactor: 8f93ef1#diff-17d1bb74f1a0f749598b5ccb73caac05e9a27c3dc59f0475e26fe527f621577aR16

Changes

  • Removes @Inject(IConfigurationService) as it doesn't apply to SwapOrderHelper

@fmrsabino fmrsabino added the bug Something isn't working label Apr 22, 2024
@fmrsabino fmrsabino self-assigned this Apr 22, 2024
@fmrsabino fmrsabino requested a review from a team as a code owner April 22, 2024 10:59
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8782887123

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 92.646%
Totals Coverage Status
Change from base Build 8782448346: 0.009%
Covered Lines: 6869
Relevant Lines: 7165
💛 - Coveralls

@fmrsabino fmrsabino merged commit 54363c7 into main Apr 22, 2024
16 checks passed
@fmrsabino fmrsabino deleted the fix-swap-order-di branch April 22, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorgomezv hectorgomezv hectorgomezv approved these changes

Assignees

@fmrsabino fmrsabino

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fmrsabino @coveralls @hectorgomezv