Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary module imports #1438

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

fmrsabino
Copy link
Collaborator

Summary

Some modules are not required to be included in the TransactionsViewControllerModule as these dependencies are already injected and included correctly in the respective dependencies.

Changes

  • Removes SwapOrderMapperModule, SwapsRepositoryModule and TokenRepositoryModule from the TransactionsViewControllerModule.

@fmrsabino fmrsabino self-assigned this Apr 22, 2024
@fmrsabino fmrsabino requested a review from a team as a code owner April 22, 2024 13:27
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8784895832

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 92.259%

Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/tests/human-description.builder.ts 1 90.0%
Totals Coverage Status
Change from base Build 8784763765: 0.03%
Covered Lines: 6894
Relevant Lines: 7220

💛 - Coveralls

@fmrsabino fmrsabino merged commit 4cd2d05 into main Apr 22, 2024
16 checks passed
@fmrsabino fmrsabino deleted the remove-unecessary-module-imports branch April 22, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants