Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add const assertions to order.builder #1447

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Add const assertions to order.builder #1447

merged 1 commit into from
Apr 23, 2024

Conversation

fmrsabino
Copy link
Collaborator

Summary

In order to further narrow down the types used with Faker to create an Order, const assertions were added to the array elements used.

Changes

  • Adds const assertions to kind, sellTokenBalance, buyTokenBalance, signingScheme and placementError.

@fmrsabino fmrsabino self-assigned this Apr 23, 2024
@fmrsabino fmrsabino requested a review from a team as a code owner April 23, 2024 08:31
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8797320691

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 92.328%
Totals Coverage Status
Change from base Build 8797074525: 0.01%
Covered Lines: 6958
Relevant Lines: 7274
💛 - Coveralls

@fmrsabino fmrsabino merged commit 7127009 into main Apr 23, 2024
16 checks passed
@fmrsabino fmrsabino deleted the add-const-order-builder branch April 23, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamacook iamacook iamacook approved these changes

Assignees

@fmrsabino fmrsabino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fmrsabino @coveralls @iamacook