Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align usage of page schema factory #1449

Merged
merged 14 commits into from
Apr 24, 2024
Merged

Align usage of page schema factory #1449

merged 14 commits into from
Apr 24, 2024

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Apr 23, 2024

Summary

There were some instances across the app where the full Page response from datasources was not being validated (only the Page['results'], whereas others were.

This aligns validation of the entire Page across the project, creating Page schemas from "base" ones.

Changes

  • Rename buildZodPageSchema to buildPageSchema
  • Create and migrate from ChainSchema to ChainPageSchema
  • Create and migrate from CollectibleSchema to CollectiblePageSchema
  • Create and migrate from DelegateSchema to DelegatePageSchema
  • Update associated tests accordingly

@iamacook iamacook self-assigned this Apr 23, 2024
@iamacook iamacook requested a review from a team as a code owner April 23, 2024 09:51
@coveralls
Copy link

coveralls commented Apr 23, 2024

Pull Request Test Coverage Report for Build 8817372843

Details

  • 29 of 29 (100.0%) changed or added relevant lines in 15 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 92.338%

Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/tests/human-description.builder.ts 1 90.0%
src/routes/transactions/mappers/common/transaction-info.mapper.ts 1 78.41%
Totals Coverage Status
Change from base Build 8817297619: -0.05%
Covered Lines: 6878
Relevant Lines: 7187

💛 - Coveralls

@fmrsabino fmrsabino added the in review Someone is reviewing this Pull Request label Apr 24, 2024
fmrsabino
fmrsabino previously approved these changes Apr 24, 2024
@fmrsabino fmrsabino removed the in review Someone is reviewing this Pull Request label Apr 24, 2024
Base automatically changed from remove-ajv to main April 24, 2024 13:22
@iamacook iamacook dismissed fmrsabino’s stale review April 24, 2024 13:22

The base branch was changed.

@iamacook iamacook requested a review from fmrsabino April 24, 2024 13:22
@iamacook iamacook merged commit e5150cb into main Apr 24, 2024
16 checks passed
@iamacook iamacook deleted the align-page-schema-factory branch April 24, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants