Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward the Order receiver #1452

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Forward the Order receiver #1452

merged 1 commit into from
Apr 24, 2024

Conversation

fmrsabino
Copy link
Collaborator

Summary

A CoW Swap Order contains an optional receiver which represents the target address that should receive the proceeds from the trade. This field is required by the clients of this service API so it should be forwarded.

Changes

  • Forwards the Order receiver in the Confirmation View and Transaction decoding

@fmrsabino fmrsabino self-assigned this Apr 24, 2024
@fmrsabino fmrsabino requested a review from a team as a code owner April 24, 2024 16:12
Comment on lines +95 to +99
@ApiPropertyOptional({
type: String,
nullable: true,
description: 'The (optional) address to receive the proceeds of the trade',
})
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Open API docs regarding the Order should be mostly the same which points to sharing these decorators. However that would require creating an abstract class with this information (which we can consider).

So far, we strived for composing the different components over inheriting them (in the Swaps feature).

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8819787228

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 92.383%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/transactions/entities/confirmation-view/confirmation-view.entity.ts 1 2 50.0%
src/routes/transactions/entities/swaps/swap-order-info.entity.ts 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/confirmation-view/confirmation-view.entity.ts 1 63.46%
src/routes/transactions/entities/tests/human-description.builder.ts 1 90.0%
src/routes/transactions/entities/swaps/swap-order-info.entity.ts 1 56.76%
Totals Coverage Status
Change from base Build 8818908625: -0.03%
Covered Lines: 6881
Relevant Lines: 7191

💛 - Coveralls

@fmrsabino fmrsabino merged commit 6690355 into main Apr 24, 2024
16 checks passed
@fmrsabino fmrsabino deleted the forward-order-receiver branch April 24, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants