Allow Swap App restriction #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8845849526Details
💛 - Coveralls |
iamacook
approved these changes
Apr 26, 2024
iamacook
reviewed
Apr 26, 2024
| @@ -29,6 +36,13 @@ export class SwapOrderMapper { | |||
| orderUid, | |||
| }); | |||
|
|
|||
| if ( | |||
| this.restrictApps && | |||
| !this.allowedApps.has(order.fullAppData['appCode']) | |||
There was a problem hiding this comment.
I think it would be good to add a comment with a link to the CoW docs here. What do you think?
There was a problem hiding this comment.
Maybe in the Config itself what do you think?
There was a problem hiding this comment.
Either is a good idea for future reference.
There was a problem hiding this comment.
Added in 37f640f
iamacook
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the ability to restrict the decoding functionality to specific Swap applications. Swap applications can be identified with Metadata that is added to each order by the respective apps. The property which contains this metadata is
fullAppData– https://explorer.cow.fi/appdata?tab=encodeChanges
SWAPS_RESTRICT_APPS– this configuration controls if the App restriction should be enabled or disabled.SWAPS_ALLOWED_APPS– this configuration contains the comma separated collection of Swap apps which are allowed to be decoded. This configuration only has an effect ifSWAPS_RESTRICT_APPSis set totrue.