Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no-useless-escape instances #1463

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Fix no-useless-escape instances #1463

merged 1 commit into from
Apr 26, 2024

Conversation

iamacook
Copy link
Member

Summary

When updating to ESLint 9, some rules had to be ignored as their recommendations changed. Of which, was the no-useless-escape rule.

This removes unnecessary escape characters present in the project.

Changes

  • Enable no-useless-escape ESLint rule
  • Remove unnecessary escape characters from:
    • app.provider.ts
    • domain/account/entities/account.entity.ts
    • routes/transactions/mappers/common/safe-app-info.mapper.spec.ts

@iamacook iamacook self-assigned this Apr 26, 2024
@iamacook iamacook requested a review from a team as a code owner April 26, 2024 09:08
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8845890145

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 91.873%

Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/tests/human-description.builder.ts 2 80.0%
Totals Coverage Status
Change from base Build 8845798531: -0.02%
Covered Lines: 6881
Relevant Lines: 7225

💛 - Coveralls

Copy link
Collaborator

@fmrsabino fmrsabino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@iamacook iamacook merged commit e763435 into main Apr 26, 2024
16 checks passed
@iamacook iamacook deleted the no-useless-escape branch April 26, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants