Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge balance entities and schemas #1476

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Apr 29, 2024

Summary

Now that our migration to Zod is complete, a lot of entities are one-liners that infer their types from schemas. Towards the end of migration, we started to combile entities and their relative schemas in the same file. This does the same with the balance-related entities.

Changes

  • Combine and balance.schema.ts and balance.entity.ts
  • Move BalanceTokenSchema and tests to balance.token.entity/balance.token.entity.spec.ts
  • Update associated imports, builders and tests

@iamacook iamacook self-assigned this Apr 29, 2024
@iamacook iamacook requested a review from a team as a code owner April 29, 2024 07:48
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8875082894

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-1.0%) to 91.878%

Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/tests/human-description.builder.ts 1 80.0%
Totals Coverage Status
Change from base Build 8850717076: -1.0%
Covered Lines: 6896
Relevant Lines: 7241

💛 - Coveralls

@iamacook iamacook enabled auto-merge (squash) April 29, 2024 07:58
@iamacook iamacook merged commit fdd3fc0 into main Apr 29, 2024
16 checks passed
@iamacook iamacook deleted the merge-balance-entity-schema branch April 29, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants