Instantiate an AuthPayload from request
#1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8881628851Details
💛 - Coveralls |
fmrsabino
requested changes
Apr 29, 2024
| chain_id?: string; | ||
| signer_address?: `0x${string}`; | ||
|
|
||
| constructor(props?: { signer_address?: `0x${string}`; chain_id?: string }) { |
There was a problem hiding this comment.
We can make the signer_address and the chain_id required here.
There was a problem hiding this comment.
I changed it to AuthPayloadDto in 880cda4.
Comment on lines
69
to
72
| new AuthPayload({ | ||
| chain_id: undefined, | ||
| signer_address: undefined, | ||
| }), |
There was a problem hiding this comment.
If the chain_id and signer_address are required, we can change this to:
expect(authPayloadFromDecoractor).toStrictEqual(new AuthPayload());
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Authorisation will require comparison of the chain or signer address to the session present in the request. This creates an
AuthGuardentity that has helpers for achieving this. It is instantiated by theAuthdecorator according to the session present in the requestChanges
AuthPayloadtoAuthPayloadDtoAuthPayloadentityAuthPayloadinAuthdecorator