Extract allowed apps to SwapOrderHelper #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmrsabino
force-pushed
the
move-allowed-app-to-helper
branch
from
39165db
to
21694de
Compare
Pull Request Test Coverage Report for Build 8886059347Details
💛 - Coveralls |
iamacook
approved these changes
Apr 29, 2024
| /** | ||
| * Checks if the app associated with an order is allowed. | ||
| * | ||
| * @param order |
There was a problem hiding this comment.
Nit: this is missing a description.
There was a problem hiding this comment.
Fixed in 4f1ee88
| @@ -16,6 +16,9 @@ import { SwapsRepositoryModule } from '@/domain/swaps/swaps-repository.module'; | |||
|
|
|||
| @Injectable() | |||
| export class SwapOrderHelper { | |||
| private readonly restrictApps = | |||
| this.configurationService.getOrThrow('swaps.restrictApps'); | |||
There was a problem hiding this comment.
Nit: restrictApps is of type unknown, I'd declare it as boolean:
private readonly restrictApps: boolean = ...
Or parametrise the function call:
this.configurationService.getOrThrow<boolean>('swaps.restrictApps')
There was a problem hiding this comment.
Fixed in 4f1ee88
hectorgomezv
approved these changes
Apr 29, 2024
iamacook
approved these changes
Apr 30, 2024
hectorgomezv
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moves the "allowed apps" logic from the
SwapOrderMapperto theSwapOrderHelper. The mapper is specific to the transaction history/queue logic while the helper is a class that can be used across the different route.With this new functionality in
SwapOrderHelper, we can now check if a specific application is allowed in other parts of the service.Changes
SwapOrderMapperto theSwapOrderHelper