Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge message (confirmation) entities and schemas #1488

Merged
merged 3 commits into from
May 2, 2024
Merged

Conversation

iamacook
Copy link
Member

Summary

Now that our migration to Zod is complete, a lot of entities are one-liners that infer their types from schemas. Towards the end of migration, we started to combile entities and their relative schemas in the same file. This does the same with the message-related entities.

Changes

  • Move MessageConfirmationSchema to domain/messages/entities/message-confirmation.entity.ts
  • Move Message(Page)Schema to domain/messages/entities/message.entity.ts
  • Split the schema-related tests into domain/messages/entities/message(-confirmation-)entity.spec.ts

@iamacook iamacook self-assigned this Apr 30, 2024
@iamacook iamacook requested a review from a team as a code owner April 30, 2024 07:17
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8890827835

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 92.272%

Files with Coverage Reduction New Missed Lines %
src/routes/transactions/mappers/common/transaction-info.mapper.ts 1 78.41%
Totals Coverage Status
Change from base Build 8890427816: 0.002%
Covered Lines: 6893
Relevant Lines: 7207

💛 - Coveralls

@iamacook iamacook merged commit 9891303 into main May 2, 2024
16 checks passed
@iamacook iamacook deleted the messages-entities branch May 2, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants