Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LTS Node.js version #1492

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Use LTS Node.js version #1492

merged 3 commits into from
Apr 30, 2024

Conversation

hectorgomezv
Copy link
Member

Summary

Closes #1490

This PR aims to change the Node.js version to the LTS one (long-term support).

This is a no-change as this lts tag references the same version that the service was using before this PR (v20.12.2)

Changes

  • Changes the Node.js version reference to LTS.

@hectorgomezv hectorgomezv self-assigned this Apr 30, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner April 30, 2024 10:39
@hectorgomezv hectorgomezv linked an issue Apr 30, 2024 that may be closed by this pull request
Use lts Node.js version #1490
Closed
@hectorgomezv hectorgomezv changed the title 1490 use lts nodejs version Use LTS Node.js version Apr 30, 2024
@coveralls
Copy link

coveralls commented Apr 30, 2024 •
edited

Pull Request Test Coverage Report for Build 8895839629

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 92.185%
Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/tests/human-description.builder.ts 4 60.0%
Totals Coverage Status
Change from base Build 8894806878: -0.04%
Covered Lines: 6896
Relevant Lines: 7215
💛 - Coveralls

@fmrsabino fmrsabino added the in review Someone is reviewing this Pull Request label Apr 30, 2024
fmrsabino
fmrsabino reviewed Apr 30, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@fmrsabino fmrsabino removed the in review Someone is reviewing this Pull Request label Apr 30, 2024
fmrsabino
fmrsabino approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@fmrsabino fmrsabino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🚀

@hectorgomezv hectorgomezv merged commit f1a1341 into main Apr 30, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the 1490-use-lts-nodejs-version branch April 30, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmrsabino fmrsabino fmrsabino approved these changes

@iamacook iamacook iamacook approved these changes

Assignees

@hectorgomezv hectorgomezv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use lts Node.js version
4 participants
@hectorgomezv @coveralls @fmrsabino @iamacook