Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TestQueuesApiModule in controller tests #1495

Merged
merged 1 commit into from
May 2, 2024

Conversation

hectorgomezv
Copy link
Member

Summary

This PR changes the AppModule created on controller tests: the module used for running these tests should be TestQueuesApiModule instead of QueuesApiModule. Controller tests shouldn’t need any running RabbitMQ instance and shouldn’t use the runtime RabbitMQ connection logic.

Changes

  • Override QueuesApiModule with TestQueuesApiModule on controller tests.

@hectorgomezv hectorgomezv self-assigned this Apr 30, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner April 30, 2024 23:05
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8902726747

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 92.174%

Files with Coverage Reduction New Missed Lines %
src/routes/transactions/mappers/common/transaction-info.mapper.ts 1 78.41%
Totals Coverage Status
Change from base Build 8894806878: -0.05%
Covered Lines: 6899
Relevant Lines: 7215

💛 - Coveralls

@fmrsabino fmrsabino added the in review Someone is reviewing this Pull Request label May 2, 2024
Copy link
Collaborator

@fmrsabino fmrsabino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fmrsabino fmrsabino removed the in review Someone is reviewing this Pull Request label May 2, 2024
@hectorgomezv hectorgomezv merged commit af8ee70 into main May 2, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the use-test-queues-api-module-in-tests branch May 2, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants