Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique queue names per E2E test suite #1497

Merged
merged 1 commit into from
May 6, 2024

Conversation

hectorgomezv
Copy link
Member

Summary

This PR addresses the interference issue between several running Node.js processes while executing Jest tests in parallel.

Before this PR, a Jest test process could emit messages to a queue, and a different process could receive them. This was causing problems like a mismatch between the cache keys being cleared, as several test suites have isolated cache key namespaces.

To avoid this kind of side effects, this PR adds a queue parameter to the test RabbitMQ client, so each test suite has the possibility of using a different queue, and therefore avoiding side effects between processes.

Changes

  • Adds a queue parameter to amqpClientFactory, so the client class can choose using a custom queue name.

@hectorgomezv hectorgomezv self-assigned this May 2, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner May 2, 2024 13:34
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8924783419

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 92.191%

Totals Coverage Status
Change from base Build 8923924899: -0.04%
Covered Lines: 6904
Relevant Lines: 7219

💛 - Coveralls

@hectorgomezv hectorgomezv merged commit 5080bec into main May 6, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the add-queue-namespaces-in-e2e-tests branch May 6, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants