Add SAFE_CREATED as a no-action event #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorgomezv
commented
May 3, 2024
Comment on lines
1
to
16
| export const enum EventType { | ||
| CHAIN_UPDATE = 'CHAIN_UPDATE', | ||
| NEW_CONFIRMATION = 'NEW_CONFIRMATION', | ||
| DELETED_MULTISIG_TRANSACTION = 'DELETED_MULTISIG_TRANSACTION', | ||
| EXECUTED_MULTISIG_TRANSACTION = 'EXECUTED_MULTISIG_TRANSACTION', | ||
| PENDING_MULTISIG_TRANSACTION = 'PENDING_MULTISIG_TRANSACTION', | ||
| INCOMING_TOKEN = 'INCOMING_TOKEN', | ||
| INCOMING_ETHER = 'INCOMING_ETHER', | ||
| INCOMING_TOKEN = 'INCOMING_TOKEN', | ||
| MESSAGE_CONFIRMATION = 'MESSAGE_CONFIRMATION', | ||
| MESSAGE_CREATED = 'MESSAGE_CREATED', | ||
| MODULE_TRANSACTION = 'MODULE_TRANSACTION', | ||
| OUTGOING_TOKEN = 'OUTGOING_TOKEN', | ||
| NEW_CONFIRMATION = 'NEW_CONFIRMATION', | ||
| OUTGOING_ETHER = 'OUTGOING_ETHER', | ||
| MESSAGE_CREATED = 'MESSAGE_CREATED', | ||
| MESSAGE_CONFIRMATION = 'MESSAGE_CONFIRMATION', | ||
| OUTGOING_TOKEN = 'OUTGOING_TOKEN', | ||
| PENDING_MULTISIG_TRANSACTION = 'PENDING_MULTISIG_TRANSACTION', | ||
| SAFE_APPS_UPDATE = 'SAFE_APPS_UPDATE', | ||
| DELETED_MULTISIG_TRANSACTION = 'DELETED_MULTISIG_TRANSACTION', | ||
| SAFE_CREATED = 'SAFE_CREATED', | ||
| } |
There was a problem hiding this comment.
I'm just sorting the keys in alphabetical order here, besides adding SAFE_CREATED.
Pull Request Test Coverage Report for Build 8937173593Details
💛 - Coveralls |
iamacook
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before this PR, and after the migration to the queue-based events reception,
SAFE_CREATEDevents were being validated againstWebHookSchema, and this validation was generating errors. This PR adds theSAFE_CREATEDevent to the events known by the CGW but does not associate any action (cache invalidation, etc.) to the reception of this event.Changes
SAFE_CREATEDevent (without any associated action).