Map historical transactions before grouping them #1505
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This simplifies the mapping of historical transactions in preparation for tackling address poisoning, breaking down #1428.
We currently group domain transactions "as is". This means that we have duplicate logic for extracting the timestamp of domain transactions (of varying types) that is otherwise done in their respective mappers, e.g. for multisig transactions.
This maps domain transactions before grouping them, as well as simplifying the grouping logic. (This will allow for simpler filtering of address poisoning attempts as all transactions will be the same type.)
Changes
mapGroupTransactions
to only map singular transaction (mapTransaction
)