Only return awaiting confirmations count if it is required

[iamacook]

Summary

awaitingConfirmation was previously being calculated according to whether walletAddress had submitted a confirmation, regardless of whether a sufficient confirmations exist. This meant that a fully confirmed transaction, when not signed by the given walletAddress, would still increase the awaiting confirmation count.

This now takes confirmationsRequired into account, only returning an awaiting count if it is > 0.

Changes

• Take the confirmationsRequired into account when increasing the awaiting confirmation count
• Add test coverage

[coveralls]

Pull Request Test Coverage Report for Build 8970682678

Details

• 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.04%) to 93.03%

---

Files with Coverage Reduction	New Missed Lines	%
src/routes/transactions/entities/tests/human-description.builder.ts	2	80.0%

Totals
Change from base Build 8970019120:	-0.04%
Covered Lines:	7016
Relevant Lines:	7268

---

💛 - Coveralls

[katspaugh]

A slight optimization

Suggested change

	const isSignedByWallet = confirmations?.some((confirmation) => {
	const isSignable = !isConfirmed && !confirmations?.some((confirmation) => {

[iamacook]

Added in 1dcf67e.