Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate overview walletAddress query #1509

Merged
merged 2 commits into from
May 7, 2024
Merged

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented May 6, 2024

Summary

This adds validation of the walletAddress query param on the overview endpoint as the endpoint is still in development.

Changes

  • Add AddressSchema validation pipe to walletAddress query

@iamacook iamacook self-assigned this May 6, 2024
@iamacook iamacook requested a review from a team as a code owner May 6, 2024 14:25
@iamacook iamacook marked this pull request as draft May 6, 2024 14:28
@iamacook iamacook marked this pull request as ready for review May 6, 2024 14:30
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8970826202

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 93.102%

Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/tests/human-description.builder.ts 1 90.0%
Totals Coverage Status
Change from base Build 8970019120: 0.03%
Covered Lines: 7016
Relevant Lines: 7267

💛 - Coveralls

@iamacook iamacook enabled auto-merge (squash) May 6, 2024 14:42
@iamacook iamacook merged commit 30f8ada into main May 7, 2024
16 checks passed
@iamacook iamacook deleted the wallet-address-validation branch May 7, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants