Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include current nonce in recommended-nonce route #817

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Conversation

fmrsabino
Copy link
Collaborator

  • Changes the endpoint route from GET /v1/chains/:chainId/safes/:safeAddress/recommended-nonce to GET /v1/chains/:chainId/safes/:safeAddress/nonces
  • The returned successful response now contains the current Safe nonce under currentNonce.
  • The recommended nonce is now returned in recommendedNonce.
  • This route is now behind a feature flag. To enable this route, FF_NONCES_ROUTE should be set to true.
GET /v1/chains/:chainId/safes/:safeAddress/nonces

{
  "currentNonce": <number>,
  "recommendedNonce": <number>
}

@fmrsabino fmrsabino self-assigned this Oct 31, 2023
@fmrsabino fmrsabino requested a review from a team as a code owner October 31, 2023 13:41
@coveralls
Copy link

coveralls commented Oct 31, 2023

Pull Request Test Coverage Report for Build 6719080103

  • 22 of 22 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 91.289%

Totals Coverage Status
Change from base Build 6719026605: -0.01%
Covered Lines: 4955
Relevant Lines: 5298

💛 - Coveralls

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@fmrsabino fmrsabino merged commit 22dd0b7 into main Nov 1, 2023
16 checks passed
@fmrsabino fmrsabino deleted the safe-nonce-state branch November 1, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants