Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move E2E vars. to setup #819

Merged
merged 1 commit into from
Oct 31, 2023
Merged

chore: move E2E vars. to setup #819

merged 1 commit into from
Oct 31, 2023

Conversation

iamacook
Copy link
Member

This moves the ALERTS_PROVIDER_API_KEY, ALERTS_PROVIDER_ACCOUNT, ALERTS_PROVIDER_PROJECT env. vars. to the E2E setup as they are not required in the CI.

@iamacook iamacook self-assigned this Oct 31, 2023
@iamacook iamacook requested a review from a team as a code owner October 31, 2023 14:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6707776116

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.309%
Totals Coverage Status
Change from base Build 6707376995: 0.0%
Covered Lines: 4948
Relevant Lines: 5292
💛 - Coveralls

fmrsabino
fmrsabino approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@fmrsabino fmrsabino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@iamacook iamacook merged commit 6d2a9ba into main Oct 31, 2023
16 checks passed
@iamacook iamacook deleted the e2e-alerts-vars branch October 31, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmrsabino fmrsabino fmrsabino approved these changes

Assignees

@iamacook iamacook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iamacook @coveralls @fmrsabino