Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FF_MESSAGES_CACHE feature flag cleaning #851

Merged
merged 1 commit into from
Nov 16, 2023
Merged

FF_MESSAGES_CACHE feature flag cleaning #851

merged 1 commit into from
Nov 16, 2023

Conversation

hectorgomezv
Copy link
Member

@hectorgomezv hectorgomezv commented Nov 14, 2023 •
edited

This PR cleans FF_MESSAGES_CACHE feature flag and its associated code.

The changes on this PR are equivalent to setting the former FF_MESSAGES_CACHE permanently to true.

@hectorgomezv hectorgomezv requested a review from a team as a code owner November 14, 2023 15:31
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6865811700

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 90.447%
Totals Coverage Status
Change from base Build 6865284643: 0.07%
Covered Lines: 5111
Relevant Lines: 5518
💛 - Coveralls

fmrsabino
fmrsabino approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@fmrsabino fmrsabino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hectorgomezv hectorgomezv merged commit 65451b2 into main Nov 16, 2023
16 checks passed
@hectorgomezv hectorgomezv deleted the remove-ff-messages-cache branch November 16, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmrsabino fmrsabino fmrsabino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hectorgomezv @coveralls @fmrsabino