Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Version and Builder Number to Docker image #1085

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Conversation

fmrsabino
Copy link
Collaborator

  • Adds the following build arguments:
    • VERSION – represents the version of the application (e.g.: semver). It is accessible across the app via settings.APPLICATION_VERSION.
    • BUILD_NUMBER – represents the build version of the application (e.g.: build hash). It is accessible across the app via settings.APPLICATION_BUILD_NUMBER
  • With the added support for the build arguments, the version of the application can now be set during the docker image building process instead of bundling the version with the application.

- Adds the following build arguments:
  * `VERSION` – represents the version of the application (e.g.: semver). It is accessible across the app via `settings.APPLICATION_VERSION`.
  * `BUILD_NUMBER` – represents the build version of the application (e.g.: build hash). It is accessible across the app via `settings.APPLICATION_BUILD_NUMBER`
- With the added support for the build arguments, the version of the application can now be set during the docker image building process instead of bundling the version with the application.
@fmrsabino fmrsabino added enhancement New feature or request docker Pull requests that update Docker code labels Mar 27, 2024
@fmrsabino fmrsabino self-assigned this Mar 27, 2024
@fmrsabino fmrsabino requested a review from a team as a code owner March 27, 2024 15:36
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8454487050

Details

  • 20 of 20 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.891%

Totals Coverage Status
Change from base Build 8437426004: 0.0%
Covered Lines: 4595
Relevant Lines: 4600

💛 - Coveralls

@fmrsabino fmrsabino merged commit fbb334b into main Apr 1, 2024
15 checks passed
@fmrsabino fmrsabino deleted the tag-version-docker branch April 1, 2024 21:14
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docker Pull requests that update Docker code enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants